Spree/PayPal Address Preferences #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this is to give a store operator the tools needed to be able to place seller protection elibible payments against Paypal. The changes are: * Creating a no_shipping preference to give the store developer a say in whether to send the shipping address. (spree-contrib#113) * Adds the ability to send a shipping address to Paypal (see spree-contrib#113) * Adds the option of displaying the shipping address on the Paypal pages. * Upgrades the Paypal SDK gem * Adds the ability to request a confirmed shipping address from Paypal. * Extracts the confirmed address from the Paypal express checkout details when we are configured to require a confirmed shipping address.
Pushing to the branch is the only way I have to retry the specs on travis-ci.
|
What's the status of this pull? |
|
It was ready to merge a long, long time ago... I'm fine bringing the code up to date and address the merge issues to get it back to a state where it can be merged if there's still interest in it. |
|
Thank you for your work @fredjean! 🍻 I'm wondering why is this PR not merged yet. |
|
Just ran hard into this exact issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns raised in #113 by allowing the store administrator to decide how addresses are presented and handled.
Allows the store administrator to:
Also contains code that adjusts the feature specs based on which layout is provided by PayPal.